feat(cpp-object-oriented-modular-refactoring): step 3 - foundation-google-style
This commit is contained in:
@@ -89,10 +89,10 @@ const fesa::ShellNodeInitialFrame& frameFor(
|
||||
void expectFailureCode(
|
||||
const fesa::Result<fesa::ShellGeometry>& result,
|
||||
const std::string& code) {
|
||||
ASSERT_FALSE(result.hasValue());
|
||||
EXPECT_EQ(result.status().failureCategory(), fesa::FailureCategory::model);
|
||||
ASSERT_EQ(result.status().diagnostics().size(), 1U);
|
||||
EXPECT_EQ(result.status().diagnostics()[0].code, code);
|
||||
ASSERT_FALSE(result.HasValue());
|
||||
EXPECT_EQ(result.GetStatus().Category(), fesa::FailureCategory::kModel);
|
||||
ASSERT_EQ(result.GetStatus().Diagnostics().size(), 1U);
|
||||
EXPECT_EQ(result.GetStatus().Diagnostics()[0].code, code);
|
||||
}
|
||||
|
||||
} // namespace
|
||||
@@ -107,12 +107,12 @@ TEST(Mitc4Geometry, BuildsDeterministicFramesForPlanarRotatedAndWarpedElements)
|
||||
auto planar = fesa::preprocessShellGeometry(
|
||||
planarNodes, {element(10U, {0U, 1U, 2U, 3U})}, sections());
|
||||
|
||||
ASSERT_TRUE(planar.hasValue());
|
||||
ASSERT_EQ(planar.value().elementData.size(), 1U);
|
||||
expectVectorNear(planar.value().elementData[0].normalCandidate, {0.0, 0.0, 1.0});
|
||||
EXPECT_NEAR(planar.value().elementData[0].surfaceAreaWeight, 1.0, 1.0e-12);
|
||||
ASSERT_EQ(planar.value().nodalFrames.size(), 4U);
|
||||
for (const auto& frame : planar.value().nodalFrames) {
|
||||
ASSERT_TRUE(planar.HasValue());
|
||||
ASSERT_EQ(planar.Value().elementData.size(), 1U);
|
||||
expectVectorNear(planar.Value().elementData[0].normalCandidate, {0.0, 0.0, 1.0});
|
||||
EXPECT_NEAR(planar.Value().elementData[0].surfaceAreaWeight, 1.0, 1.0e-12);
|
||||
ASSERT_EQ(planar.Value().nodalFrames.size(), 4U);
|
||||
for (const auto& frame : planar.Value().nodalFrames) {
|
||||
expectVectorNear(frame.director, {0.0, 0.0, 1.0});
|
||||
expectVectorNear(frame.tangentA, {1.0, 0.0, 0.0});
|
||||
expectVectorNear(frame.tangentB, {0.0, 1.0, 0.0});
|
||||
@@ -127,8 +127,8 @@ TEST(Mitc4Geometry, BuildsDeterministicFramesForPlanarRotatedAndWarpedElements)
|
||||
auto rotated = fesa::preprocessShellGeometry(
|
||||
rotatedNodes, {element(11U, {0U, 1U, 2U, 3U})}, sections());
|
||||
|
||||
ASSERT_TRUE(rotated.hasValue());
|
||||
const auto& rotatedFrame = frameFor(rotated.value(), 0U);
|
||||
ASSERT_TRUE(rotated.HasValue());
|
||||
const auto& rotatedFrame = frameFor(rotated.Value(), 0U);
|
||||
expectVectorNear(rotatedFrame.director, {1.0, 0.0, 0.0});
|
||||
expectVectorNear(rotatedFrame.tangentA, {0.0, 1.0, 0.0});
|
||||
expectVectorNear(rotatedFrame.tangentB, {0.0, 0.0, 1.0});
|
||||
@@ -142,9 +142,9 @@ TEST(Mitc4Geometry, BuildsDeterministicFramesForPlanarRotatedAndWarpedElements)
|
||||
auto warped = fesa::preprocessShellGeometry(
|
||||
warpedNodes, {element(12U, {0U, 1U, 2U, 3U})}, sections());
|
||||
|
||||
ASSERT_TRUE(warped.hasValue());
|
||||
EXPECT_GT(warped.value().elementData[0].surfaceAreaWeight, 2.0);
|
||||
for (const auto& frame : warped.value().nodalFrames) {
|
||||
ASSERT_TRUE(warped.HasValue());
|
||||
EXPECT_GT(warped.Value().elementData[0].surfaceAreaWeight, 2.0);
|
||||
for (const auto& frame : warped.Value().nodalFrames) {
|
||||
expectRightHandedFrame(frame);
|
||||
}
|
||||
}
|
||||
@@ -166,13 +166,13 @@ TEST(Mitc4Geometry, AreaWeightsSharedDirectorsInStableSourceIdentityOrder) {
|
||||
auto second = fesa::preprocessShellGeometry(
|
||||
nodes, {flat, tilted}, sections());
|
||||
|
||||
ASSERT_TRUE(first.hasValue());
|
||||
ASSERT_TRUE(second.hasValue());
|
||||
ASSERT_TRUE(first.HasValue());
|
||||
ASSERT_TRUE(second.HasValue());
|
||||
const Vector3 expectedSharedDirector{
|
||||
-1.0 / std::sqrt(5.0), 0.0, 2.0 / std::sqrt(5.0)};
|
||||
for (const auto sharedNode : {1U, 2U}) {
|
||||
const auto& firstFrame = frameFor(first.value(), sharedNode);
|
||||
const auto& secondFrame = frameFor(second.value(), sharedNode);
|
||||
const auto& firstFrame = frameFor(first.Value(), sharedNode);
|
||||
const auto& secondFrame = frameFor(second.Value(), sharedNode);
|
||||
expectVectorNear(firstFrame.director, expectedSharedDirector);
|
||||
expectVectorNear(firstFrame.director, secondFrame.director, 0.0);
|
||||
expectVectorNear(firstFrame.tangentA, {0.0, 1.0, 0.0});
|
||||
|
||||
Reference in New Issue
Block a user