baram2584/FESADev
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

docs: align reference gate with comparison verdict

Browse Source
This commit is contained in:
KOKO\Mimi
2026-08-10 00:28:09 +09:00
parent b7a1258ce0
commit 05f11943a5
4 changed files with 38 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files
docs/reference-verifications/linear-static-3d-euler-beam-reference-verification.md
+12 -9
View File
@@ -13,6 +13,7 @@
- status: `pass-for-physics-evaluation` - status: `pass-for-physics-evaluation`
- owner_agent: `reference-verification-agent` - owner_agent: `reference-verification-agent`
- date: `2026-08-09` - date: `2026-08-09`
- review_fix_date: `2026-08-10`
The prerequisite build/test report has status The prerequisite build/test report has status
`pass-for-reference-verification`. This report applies only the approved Abaqus `pass-for-reference-verification`. This report applies only the approved Abaqus
@@ -127,11 +128,11 @@ maximum tolerance-normalized error, RMS error, norm error, and worst-row index w
recalculated from the row ledger and matched exactly. Missing rows, extra rows, recalculated from the row ledger and matched exactly. Missing rows, extra rows,
duplicate rows, nonfinite rows, and failed rows were all zero. duplicate rows, nonfinite rows, and failed rows were all zero.
The Step 26 sample acceptance probe reads `$metrics.status -eq 'pass'`, but the The authoritative TASK-24 `ComparisonReport`, test contract, serialized JSON, and
authoritative TASK-24 `ComparisonReport`, test contract, and serialized JSON define Step 26 acceptance probe all define the verdict as the boolean `passed`. Final
the verdict as the boolean `passed`. The generated JSON has no `status` field and review reproduced that the former `$metrics.status` sample failed against the valid
has `passed=true`. This report uses `passed=true`; the stale sample-field mismatch artifact, corrected the phase probe to `$metrics.passed -eq $true`, and reran the
does not change source, tests, or upstream contracts. exact acceptance chain successfully. The generated JSON has `passed=true`.
## Execution Evidence ## Execution Evidence
@@ -278,17 +279,19 @@ model-coverage adequacy.
- Abaqus_or_other_reference_solver_executed: `false` - Abaqus_or_other_reference_solver_executed: `false`
- owned_report_created: `true` - owned_report_created: `true`
- phase_index_step26_modified: `true` - phase_index_step26_modified: `true`
- phase_step26_acceptance_modified_for_review_fix: `true`
- phase_index_step26_summary_modified_for_review_fix: `true`
- generated_build_local_evidence: `true`, ignored under `.harness/build/` - generated_build_local_evidence: `true`, ignored under `.harness/build/`
- notes: comparison and HDF5 inspection were read-only with respect to the - notes: comparison and HDF5 inspection were read-only with respect to the
approved reference bundle; pre/post hashes, Git diff, and Git status agree approved reference bundle; the final review fix changed only acceptance/report/index
documentation, and pre/post hashes, Git diff, and Git status agree
## Open Issues ## Open Issues
- Non-blocking acceptance-text mismatch: Step 26's sample PowerShell reads a
nonexistent string `status`; authoritative TASK-24 code/tests/JSON use boolean
`passed=true`. No upstream file was changed in this independent gate.
- Non-blocking evidence typo: the Step 25 build/test report prints the input - Non-blocking evidence typo: the Step 25 build/test report prints the input
SHA-256 without the second `DB` after `...1DB`; the fresh 64-character pre/post SHA-256 without the second `DB` after `...1DB`; the fresh 64-character pre/post
value in this report matches the unchanged working-tree file. Reference Git value in this report matches the unchanged working-tree file. Reference Git
diff/status and the end-to-end reference snapshot check are clean. diff/status and the end-to-end reference snapshot check are clean.
- Resolved final-review finding: the Step 26 acceptance probe now reads the
authoritative boolean `passed`, and its exact command passes on the current artifact.
- No issue blocks Physics Evaluation. - No issue blocks Physics Evaluation.
docs/releases/linear-static-3d-euler-beam-release.md
+24 -14
View File
@@ -22,6 +22,7 @@
- status: `ready-for-release` - status: `ready-for-release`
- owner_agent: `release-agent` - owner_agent: `release-agent`
- date: `2026-08-10` - date: `2026-08-10`
- final_review_source_head: `b7a1258ce0f36a85b888e23470cf9d936a7595cd`
This is an internal feature-readiness verdict. It authorizes no publish, deploy, package, tag, This is an internal feature-readiness verdict. It authorizes no publish, deploy, package, tag,
push, external release, or reference-artifact operation. push, external release, or reference-artifact operation.
@@ -71,11 +72,12 @@ push, external release, or reference-artifact operation.
`completed`, all corresponding phase-index entries are `completed`, Step 25 independently audited `completed`, all corresponding phase-index entries are `completed`, Step 25 independently audited
all 18 blocks, and a fresh build/discovery/full CTest passed 83/83. The Step 25 report reaches the all 18 blocks, and a fresh build/discovery/full CTest passed 83/83. The Step 25 report reaches the
same explicit nonblocking conclusion. The upstream implementation report was not modified. same explicit nonblocking conclusion. The upstream implementation report was not modified.
- The Step 26 report records two nonblocking evidence-text defects: its sample acceptance probe - Final review reproduced that the former Step 26 sample acceptance probe rejected a valid
expects a nonexistent string `status` although the authoritative JSON/code/tests use `passed=true` artifact because it read a nonexistent string `status`. The phase probe now reads
`passed=true`, and the Step 25 prose contains a typo in the input SHA-256. Fresh Step 26/27 hashes, the authoritative boolean `passed`; its exact command was rerun successfully without changing
Git diff/status, exact row reconstruction, and passing comparison evidence preserve artifact source, tests, tolerance, or reference artifacts.
identity; neither defect changes code, tolerance, or the verdict. - The Step 25 prose contains a typo in the input SHA-256. Fresh Step 26/27 hashes, Git diff/status,
exact row reconstruction, and passing comparison evidence preserve artifact identity.
## Acceptance Traceability ## Acceptance Traceability
@@ -143,7 +145,7 @@ disposition. No must requirement is deferred or blocked.
| Step 25 fresh MSVC x64 Debug configure/build | exit 0; `/W4 /WX`; no warnings | exit 0; warning scan 0 | pass | | Step 25 fresh MSVC x64 Debug configure/build | exit 0; `/W4 /WX`; no warnings | exit 0; warning scan 0 | pass |
| Step 25 CTest discovery/full | nonzero discovery; zero failures | 83 discovered; feature 83/83; full 83/83 | pass | | Step 25 CTest discovery/full | nonzero discovery; zero failures | 83 discovered; feature 83/83; full 83/83 | pass |
| exact Build/Test gate string | `status: pass-for-reference-verification` | present | pass | | exact Build/Test gate string | `status: pass-for-reference-verification` | present | pass |
| exact Reference Verification gate string | `status: pass-for-physics-evaluation` | present; comparison test twice 1/1 | pass | | exact Reference Verification gate string and result probe | `status: pass-for-physics-evaluation`; `passed=true` | present; corrected exact acceptance command and comparison test pass | pass |
| exact Physics Evaluation gate string | `status: pass-for-release-agent` | present; targeted physics selection 17/17 | pass | | exact Physics Evaluation gate string | `status: pass-for-release-agent` | present; targeted physics selection 17/17 | pass |
| reference comparison | exact rows/metrics; approved tolerance | 176/176 rows, 16/16 metrics, `passed=true`; largest normalized error `0.026602795021994977 < 1` | pass | | reference comparison | exact rows/metrics; approved tolerance | 176/176 rows, 16/16 metrics, `passed=true`; largest normalized error `0.026602795021994977 < 1` | pass |
| physics sanity | equilibrium/sign/symmetry/section/residual/coverage pass | force `1.1921e-13`, moment `2.7418e-13`, free residual `9.3563e-13`; all checks pass | pass | | physics sanity | equilibrium/sign/symmetry/section/residual/coverage pass | force `1.1921e-13`, moment `2.7418e-13`, free residual `9.3563e-13`; all checks pass | pass |
@@ -230,7 +232,8 @@ disposition. No must requirement is deferred or blocked.
identity is unchanged, known limitations and accepted risks are documented, and no unresolved identity is unchanged, known limitations and accepted risks are documented, and no unresolved
blocker exists. blocker exists.
- authority_boundary: internal feature readiness only; no publish, deploy, package, tag, push, - authority_boundary: internal feature readiness only; no publish, deploy, package, tag, push,
commit, external release, or reference-artifact change is authorized. external release, or reference-artifact change is authorized. Harness-owned phase evidence
commits remain part of the internal development workflow, not release publication.
## Handoff Recommendation ## Handoff Recommendation
@@ -242,6 +245,7 @@ disposition. No must requirement is deferred or blocked.
| Physics Evaluation Agent | N/A; required physics review passed. | N/A | | Physics Evaluation Agent | N/A; required physics review passed. | N/A |
No release engineering, packaging, publication, tag, push, or external coordination was performed. No release engineering, packaging, publication, tag, push, or external coordination was performed.
Harness/root phase-evidence commits are internal workflow records, not an external release action.
## No-Change Assertion ## No-Change Assertion
@@ -250,15 +254,21 @@ No release engineering, packaging, publication, tag, push, or external coordinat
- cmake_files_modified: `false` - cmake_files_modified: `false`
- requirements_or_upstream_contracts_modified: `false` - requirements_or_upstream_contracts_modified: `false`
- implementation_report_modified: `false` - implementation_report_modified: `false`
- build_reference_or_physics_reports_modified: `false` - build_report_modified: `false`
- reference_verification_report_modified_for_review_fix: `true`
- physics_report_modified: `false`
- reference_artifacts_modified: `false` - reference_artifacts_modified: `false`
- tolerance_policies_modified: `false` - tolerance_policies_modified: `false`
- Abaqus_or_other_reference_solver_executed: `false` - Abaqus_or_other_reference_solver_executed: `false`
- publish_deploy_package_tag_push_commit_performed: `false` - release_agent_publish_deploy_package_tag_push_commit_performed: `false`
- harness_or_root_phase_evidence_commits_performed: `true`
- owned_release_report_created: `true` - owned_release_report_created: `true`
- phase_index_step28_modified: `true` - phase_index_step28_modified: `true`
- notes: Step 28 changes are limited to this report and the Step 28 object in the phase index; - phase_step26_acceptance_modified_for_review_fix: `true`
reference evidence and all upstream files were inspected read-only. - phase_index_step26_summary_modified_for_review_fix: `true`
- notes: The release audit initially created this report and changed only Step 28. Final review
then aligned the Step 26 acceptance probe/report/index summary with authoritative `passed=true`;
source, tests, tolerance, reference artifacts, and physical evidence remain unchanged.
## Open Issues ## Open Issues
@@ -266,9 +276,9 @@ No release engineering, packaging, publication, tag, push, or external coordinat
- Nonblocking documentation issue: the implementation report aggregate `status: in-progress` is - Nonblocking documentation issue: the implementation report aggregate `status: in-progress` is
stale; completed Step blocks, phase index, and Step 25 fresh audit are authoritative for release stale; completed Step blocks, phase index, and Step 25 fresh audit are authoritative for release
closure. It remains unchanged to preserve upstream audit independence. closure. It remains unchanged to preserve upstream audit independence.
- Nonblocking evidence-text issues: Step 26 documents the stale sample `status` probe versus - Resolved final-review finding: Step 26 now probes authoritative `passed=true`, and the exact
authoritative `passed=true`, and the Step 25 input-hash prose typo. Later exact hashes and Git acceptance command passes. The remaining Step 25 input-hash prose typo is nonblocking; later
audits resolve identity without changing artifacts. exact hashes and Git audits resolve identity without changing artifacts.
- Nonblocking accepted Minors: comparator file-type defense-in-depth coverage, future multi-source - Nonblocking accepted Minors: comparator file-type defense-in-depth coverage, future multi-source
diagnostic ordering, and alternate-HDF5 `libmmd.dll` staging portability remain as documented. diagnostic ordering, and alternate-HDF5 `libmmd.dll` staging portability remain as documented.
- Deferred behavior is limited to the Known Limitations and is not claimed as supported. - Deferred behavior is limited to the Known Limitations and is not claimed as supported.
phases/linear-static-3d-euler-beam/index.json
+1 -1
View File
@@ -216,7 +216,7 @@
"status": "completed", "status": "completed",
"started_at": "2026-08-09T23:34:22+0900", "started_at": "2026-08-09T23:34:22+0900",
"completed_at": "2026-08-09T23:43:22+0900", "completed_at": "2026-08-09T23:43:22+0900",
"summary": "Approved legacy B33 4-file artifact precheck와 read-only HDF5 schema/source identity/stress audit를 통과하고 exact B33ReferenceComparison을 두 번 1/1 실행해 deterministic comparison.json의 passed=true, 176/176 rows, 16/16 metrics, displacement/reaction/section 66/66/44 rows 및 reference immutability를 독립 검산하여 pass-for-physics-evaluation으로 인계함" "summary": "Approved legacy B33 4-file artifact precheck와 read-only HDF5 schema/source identity/stress audit를 통과하고 exact B33ReferenceComparison을 두 번 1/1 실행해 deterministic comparison.json의 passed=true, 176/176 rows, 16/16 metrics, displacement/reaction/section 66/66/44 rows 및 reference immutability를 독립 검산했으며 final review에서 exact acceptance probe도 authoritative passed boolean으로 정렬·재검증하여 pass-for-physics-evaluation으로 인계함"
}, },
{ {
"step": 27, "step": 27,
phases/linear-static-3d-euler-beam/step26.md
+1 -1
View File
@@ -68,7 +68,7 @@ ctest --test-dir .harness/build -C Debug -R B33ReferenceComparison -V --output-o
$metricsPath = '.harness/build/reference/cantilever-beam-b33/comparison.json' $metricsPath = '.harness/build/reference/cantilever-beam-b33/comparison.json'
if (-not (Test-Path $metricsPath)) { throw 'Missing comparison metrics' } if (-not (Test-Path $metricsPath)) { throw 'Missing comparison metrics' }
$metrics = Get-Content -Raw $metricsPath | ConvertFrom-Json $metrics = Get-Content -Raw $metricsPath | ConvertFrom-Json
if ($metrics.status -ne 'pass') { throw "Reference comparison failed: $($metrics.status)" } if ($metrics.passed -ne $true) { throw "Reference comparison failed: passed=$($metrics.passed)" }
git diff --exit-code -- reference/ git diff --exit-code -- reference/
``` ```