baram2584/FESADev
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor: extract results reference comparison

Browse Source
This commit is contained in:
NINI
2026-05-05 01:38:04 +09:00
parent 339bf1cbb9
commit 421ad5a707
9 changed files with 469 additions and 257 deletions
Download Patch File Download Diff File Expand all files Collapse all files
PROGRESS.md
+35 -1
View File
@@ -13,10 +13,44 @@ Every new agent session must read this file together with `PLAN.md` before plann
- Do not remove history unless the user explicitly asks for archival cleanup.
## Current Status
Phase 1 has a completed rebaseline execution path in `phases/1-linear-static-mitc4-rebaseline`. Steps 0 through 15 are complete, and P1R-15 recorded a pass-with-documented-gaps evaluator closeout. The follow-up architecture refactor phase in `phases/1-structure-alignment-refactor` is underway because the current production implementation is concentrated in `include/fesa/fesa.hpp` instead of the module directories documented in `docs/ARCHITECTURE.md`; P1A-00 through P1A-04 are complete, so the next step is P1A-05 Results/reference extraction. `quad_02_phase1.inp` is the normalized Phase 1-compatible input path for the stored `quad_02` S4 reference pair, while the original `quad_02.inp` remains preserved unsupported provenance. Core numeric aliases, DOF mapping, validation harness, model diagnostic context, the Phase 1 parser/domain subset, validation/singular diagnostics, DofManager/reaction foundation, minimum result model metadata, displacement CSV comparator foundation, MITC4 geometry/director scaffolding, MITC4 displacement/strain/tying row scaffolding, MITC4 material/transform/integration scaffolding, MITC4 stiffness/drilling/internal-force scaffolding, MITC4 patch/locking-sensitivity tests, full-space assembly, reduced projection, sparse-pattern scaffold, solver adapter injection, full-vector internal/reaction force state, active AnalysisModel construction, input-to-AnalysisState-to-U/RF result workflow, and the first stored Abaqus displacement regression have been revalidated. Full PRD Phase 1 completion still depends on the open architecture/reference gaps R-014, R-010, and R-013. The old `phases/1-linear-static-mitc4` path is historical and superseded after the MITC4 formulation reset.
Phase 1 has a completed rebaseline execution path in `phases/1-linear-static-mitc4-rebaseline`. Steps 0 through 15 are complete, and P1R-15 recorded a pass-with-documented-gaps evaluator closeout. The follow-up architecture refactor phase in `phases/1-structure-alignment-refactor` is underway because the current production implementation is concentrated in `include/fesa/fesa.hpp` instead of the module directories documented in `docs/ARCHITECTURE.md`; P1A-00 through P1A-05 are complete, so the next step is P1A-06 MITC4 geometry/strain extraction. `quad_02_phase1.inp` is the normalized Phase 1-compatible input path for the stored `quad_02` S4 reference pair, while the original `quad_02.inp` remains preserved unsupported provenance. Core numeric aliases, DOF mapping, validation harness, model diagnostic context, the Phase 1 parser/domain subset, validation/singular diagnostics, DofManager/reaction foundation, minimum result model metadata, displacement CSV comparator foundation, MITC4 geometry/director scaffolding, MITC4 displacement/strain/tying row scaffolding, MITC4 material/transform/integration scaffolding, MITC4 stiffness/drilling/internal-force scaffolding, MITC4 patch/locking-sensitivity tests, full-space assembly, reduced projection, sparse-pattern scaffold, solver adapter injection, full-vector internal/reaction force state, active AnalysisModel construction, input-to-AnalysisState-to-U/RF result workflow, and the first stored Abaqus displacement regression have been revalidated. Full PRD Phase 1 completion still depends on the open architecture/reference gaps R-014, R-010, and R-013. The old `phases/1-linear-static-mitc4` path is historical and superseded after the MITC4 formulation reset.
## Completed Work
### 2026-05-05 - P1A-05 Results reference extraction completed
Author: Codex
Changed files:
- `CMakeLists.txt`
- `include/fesa/Results/ReferenceComparison.hpp`
- `include/fesa/Results/ResultModel.hpp`
- `include/fesa/Results/Results.hpp`
- `include/fesa/fesa.hpp`
- `tests/test_results_module_includes.cpp`
- `phases/1-structure-alignment-refactor/index.json`
- `PLAN.md`
- `PROGRESS.md`
Summary:
- Extracted `FieldOutput`, `ResultFrame`, `ResultStep`, `ResultFile`, and `InMemoryResultsWriter` from the umbrella header into `include/fesa/Results/ResultModel.hpp`.
- Extracted displacement CSV loading, `ComparisonOptions`, `ComparisonResult`, and `compareDisplacements` into `include/fesa/Results/ReferenceComparison.hpp`.
- Updated `include/fesa/Results/Results.hpp` to expose the in-memory result model and reference comparator through the Results module.
- Updated `include/fesa/fesa.hpp` to include the Results module facade, preserving existing umbrella consumers and leaving Analysis workflow symbols in place for P1A-08.
- Added `fesa_results_module_tests`, a direct Results include smoke/regression test that does not include `fesa/fesa.hpp`.
- Preserved mandatory Phase 1 `U`/`RF` metadata, CSV column mapping, node-id-based matching, and the stored `quad_02_displacements.csv` loader path.
- No HDF5 dependency, reaction CSV parser, result label change, comparison tolerance change, or analysis execution change was introduced.
- Remaining large groups in `fesa.hpp` are Assembly helpers (`buildReducedSparsePattern`, `recoverFullReaction`), MITC4 Element/Material helpers, and Analysis workflow.
Verification:
- First ran `python scripts\validate_workspace.py` after adding the direct Results include test; it failed as expected because `fesa/Results/Results.hpp` did not yet expose result and comparison symbols.
- After extraction, `python scripts\validate_workspace.py` configured CMake, built `fesa_core`, `fesa_tests`, `fesa_core_module_tests`, `fesa_math_module_tests`, `fesa_io_module_tests`, and `fesa_results_module_tests`, and ran CTest successfully.
- CTest result: 5 test executables passed.
Follow-up:
- Continue with P1A-06 MITC4 geometry/strain extraction.
- Keep R-014 open until P1A-09 independently accepts the final architecture alignment.
- Keep R-010 open; missing Abaqus reaction CSV artifacts are not solved by this refactor.
### 2026-05-05 - P1A-04 IO parser extraction completed
Author: Codex