modify docu
This commit is contained in:
+168
-23
@@ -8,8 +8,10 @@ Usage:
|
||||
|
||||
import argparse
|
||||
import contextlib
|
||||
import fnmatch
|
||||
import json
|
||||
import os
|
||||
import re
|
||||
import subprocess
|
||||
import sys
|
||||
import threading
|
||||
@@ -54,6 +56,10 @@ class StepExecutor:
|
||||
"""Phase 디렉토리 안의 step들을 순차 실행하는 하네스."""
|
||||
|
||||
MAX_RETRIES = 3
|
||||
VALIDATION_COMMANDS = (
|
||||
[sys.executable, "-m", "unittest", "discover", "-s", "scripts", "-p", "test_*.py"],
|
||||
[sys.executable, "scripts/validate_workspace.py"],
|
||||
)
|
||||
FEAT_MSG = "feat({phase}): step {num} — {name}"
|
||||
CHORE_MSG = "chore({phase}): step {num} output"
|
||||
TZ = timezone(timedelta(hours=9))
|
||||
@@ -83,6 +89,7 @@ class StepExecutor:
|
||||
def run(self):
|
||||
self._print_header()
|
||||
self._check_blockers()
|
||||
self._assert_clean_worktree("before branch checkout")
|
||||
self._checkout_branch()
|
||||
guardrails = self._load_guardrails()
|
||||
self._ensure_created_at()
|
||||
@@ -110,8 +117,117 @@ class StepExecutor:
|
||||
cmd = ["git"] + list(args)
|
||||
return subprocess.run(cmd, cwd=self._root, capture_output=True, text=True)
|
||||
|
||||
def _validate_before_commit(self, commit_message: str):
|
||||
print(f" Validation before commit: {commit_message}")
|
||||
for cmd in self.VALIDATION_COMMANDS:
|
||||
r = subprocess.run(cmd, cwd=self._root, capture_output=True, text=True)
|
||||
if r.returncode != 0:
|
||||
print(f" ERROR: validation failed before commit: {' '.join(cmd)}")
|
||||
if r.stdout:
|
||||
print(r.stdout[-2000:])
|
||||
if r.stderr:
|
||||
print(r.stderr[-2000:])
|
||||
sys.exit(1)
|
||||
|
||||
def _branch_name(self) -> str:
|
||||
slug = re.sub(r"[^A-Za-z0-9._-]+", "-", self._phase_name.strip())
|
||||
slug = slug.strip("/.-")
|
||||
if not slug:
|
||||
slug = self._phase_dir_name
|
||||
return f"codex/{slug}"
|
||||
|
||||
def _assert_clean_worktree(self, context: str):
|
||||
r = self._run_git("status", "--porcelain")
|
||||
if r.returncode != 0:
|
||||
print(" ERROR: git status failed.")
|
||||
print(f" {r.stderr.strip()}")
|
||||
sys.exit(1)
|
||||
dirty = r.stdout.strip()
|
||||
if dirty:
|
||||
print(f" ERROR: dirty worktree detected {context}.")
|
||||
print(" Commit, stash, or remove these changes before running scripts/execute.py:")
|
||||
for line in dirty.splitlines():
|
||||
print(f" {line}")
|
||||
sys.exit(1)
|
||||
|
||||
@staticmethod
|
||||
def _normalize_rel_path(path: str) -> str:
|
||||
return path.replace("\\", "/").lstrip("./")
|
||||
|
||||
def _path_allowed(self, path: str, patterns: list[str]) -> bool:
|
||||
rel = self._normalize_rel_path(path)
|
||||
for raw in patterns:
|
||||
pattern = self._normalize_rel_path(str(raw))
|
||||
if not pattern:
|
||||
continue
|
||||
if pattern.endswith("/") and rel.startswith(pattern):
|
||||
return True
|
||||
if any(ch in pattern for ch in "*?[") and fnmatch.fnmatchcase(rel, pattern):
|
||||
return True
|
||||
if rel == pattern:
|
||||
return True
|
||||
return False
|
||||
|
||||
def _validate_step_allowlist(self, step: dict):
|
||||
allowed = step.get("allowed_paths")
|
||||
if (
|
||||
not isinstance(allowed, list)
|
||||
or not allowed
|
||||
or not all(isinstance(p, str) and p.strip() for p in allowed)
|
||||
):
|
||||
print(f" ERROR: Step {step.get('step')} must define non-empty allowed_paths.")
|
||||
sys.exit(1)
|
||||
|
||||
def _changed_paths(self) -> list[str]:
|
||||
paths: list[str] = []
|
||||
tracked = self._run_git("diff", "--name-only")
|
||||
if tracked.returncode != 0:
|
||||
print(" ERROR: git diff --name-only failed.")
|
||||
print(f" {tracked.stderr.strip()}")
|
||||
sys.exit(1)
|
||||
paths.extend(tracked.stdout.splitlines())
|
||||
|
||||
staged = self._run_git("diff", "--cached", "--name-only")
|
||||
if staged.returncode != 0:
|
||||
print(" ERROR: git diff --cached --name-only failed.")
|
||||
print(f" {staged.stderr.strip()}")
|
||||
sys.exit(1)
|
||||
paths.extend(staged.stdout.splitlines())
|
||||
|
||||
untracked = self._run_git("ls-files", "--others", "--exclude-standard")
|
||||
if untracked.returncode != 0:
|
||||
print(" ERROR: git ls-files --others failed.")
|
||||
print(f" {untracked.stderr.strip()}")
|
||||
sys.exit(1)
|
||||
paths.extend(untracked.stdout.splitlines())
|
||||
|
||||
return sorted({self._normalize_rel_path(p) for p in paths if p.strip()})
|
||||
|
||||
def _housekeeping_paths(self, step_num: int) -> set[str]:
|
||||
return {
|
||||
f"phases/{self._phase_dir_name}/index.json",
|
||||
f"phases/{self._phase_dir_name}/step{step_num}-output.json",
|
||||
"phases/index.json",
|
||||
}
|
||||
|
||||
def _classify_step_changes(self, step_num: int, step: dict, changed_paths: list[str]) -> tuple[list[str], list[str], list[str]]:
|
||||
allowed_patterns = step.get("allowed_paths", [])
|
||||
housekeeping_set = self._housekeeping_paths(step_num)
|
||||
allowed: list[str] = []
|
||||
housekeeping: list[str] = []
|
||||
disallowed: list[str] = []
|
||||
for path in changed_paths:
|
||||
rel = self._normalize_rel_path(path)
|
||||
if rel in housekeeping_set:
|
||||
housekeeping.append(rel)
|
||||
elif self._path_allowed(rel, allowed_patterns):
|
||||
allowed.append(rel)
|
||||
else:
|
||||
disallowed.append(rel)
|
||||
return allowed, housekeeping, disallowed
|
||||
|
||||
def _checkout_branch(self):
|
||||
branch = f"feat-{self._phase_name}"
|
||||
branch = self._branch_name()
|
||||
|
||||
r = self._run_git("rev-parse", "--abbrev-ref", "HEAD")
|
||||
if r.returncode != 0:
|
||||
@@ -133,28 +249,45 @@ class StepExecutor:
|
||||
|
||||
print(f" Branch: {branch}")
|
||||
|
||||
def _commit_step(self, step_num: int, step_name: str):
|
||||
output_rel = f"phases/{self._phase_dir_name}/step{step_num}-output.json"
|
||||
index_rel = f"phases/{self._phase_dir_name}/index.json"
|
||||
def _stage_paths(self, paths: list[str]):
|
||||
if not paths:
|
||||
return
|
||||
r = self._run_git("add", "--", *paths)
|
||||
if r.returncode != 0:
|
||||
print(" ERROR: git add failed.")
|
||||
print(f" {r.stderr.strip()}")
|
||||
sys.exit(1)
|
||||
|
||||
self._run_git("add", "-A")
|
||||
self._run_git("reset", "HEAD", "--", output_rel)
|
||||
self._run_git("reset", "HEAD", "--", index_rel)
|
||||
def _commit_step(self, step: dict, step_name: str):
|
||||
step_num = step["step"]
|
||||
changed = self._changed_paths()
|
||||
allowed, housekeeping, disallowed = self._classify_step_changes(step_num, step, changed)
|
||||
if disallowed:
|
||||
print(f" ERROR: Step {step_num} modified files outside allowed_paths:")
|
||||
for path in disallowed:
|
||||
print(f" {path}")
|
||||
sys.exit(1)
|
||||
|
||||
if self._run_git("diff", "--cached", "--quiet").returncode != 0:
|
||||
if allowed:
|
||||
msg = self.FEAT_MSG.format(phase=self._phase_name, num=step_num, name=step_name)
|
||||
r = self._run_git("commit", "-m", msg)
|
||||
if r.returncode == 0:
|
||||
self._validate_before_commit(msg)
|
||||
self._stage_paths(allowed)
|
||||
if self._run_git("diff", "--cached", "--quiet").returncode != 0:
|
||||
r = self._run_git("commit", "-m", msg)
|
||||
if r.returncode != 0:
|
||||
print(f" ERROR: code commit failed: {r.stderr.strip()}")
|
||||
sys.exit(1)
|
||||
print(f" Commit: {msg}")
|
||||
else:
|
||||
print(f" WARN: 코드 커밋 실패: {r.stderr.strip()}")
|
||||
|
||||
self._run_git("add", "-A")
|
||||
if self._run_git("diff", "--cached", "--quiet").returncode != 0:
|
||||
if housekeeping:
|
||||
msg = self.CHORE_MSG.format(phase=self._phase_name, num=step_num)
|
||||
r = self._run_git("commit", "-m", msg)
|
||||
if r.returncode != 0:
|
||||
print(f" WARN: housekeeping 커밋 실패: {r.stderr.strip()}")
|
||||
self._validate_before_commit(msg)
|
||||
self._stage_paths(housekeeping)
|
||||
if self._run_git("diff", "--cached", "--quiet").returncode != 0:
|
||||
r = self._run_git("commit", "-m", msg)
|
||||
if r.returncode != 0:
|
||||
print(f" ERROR: housekeeping commit failed: {r.stderr.strip()}")
|
||||
sys.exit(1)
|
||||
|
||||
# --- top-level index ---
|
||||
|
||||
@@ -197,6 +330,7 @@ class StepExecutor:
|
||||
return "## 이전 Step 산출물\n\n" + "\n".join(lines) + "\n\n"
|
||||
|
||||
def _build_preamble(self, guardrails: str, step_context: str,
|
||||
allowed_paths: list[str],
|
||||
prev_error: Optional[str] = None) -> str:
|
||||
commit_example = self.FEAT_MSG.format(
|
||||
phase=self._phase_name, num="N", name="<step-name>"
|
||||
@@ -211,6 +345,9 @@ class StepExecutor:
|
||||
f"당신은 {self._project} 프로젝트의 개발자입니다. 아래 step을 수행하세요.\n\n"
|
||||
f"{guardrails}\n\n---\n\n"
|
||||
f"{step_context}{retry_section}"
|
||||
f"## Step file allowlist\n\n"
|
||||
f"This step may modify only these repository-relative paths:\n"
|
||||
f"{chr(10).join(f'- {p}' for p in allowed_paths)}\n\n"
|
||||
f"## 작업 규칙\n\n"
|
||||
f"1. 이전 step에서 작성된 코드를 확인하고 일관성을 유지하라.\n"
|
||||
f"2. 이 step에 명시된 작업만 수행하라. 추가 기능이나 파일을 만들지 마라.\n"
|
||||
@@ -299,7 +436,7 @@ class StepExecutor:
|
||||
for attempt in range(1, self.MAX_RETRIES + 1):
|
||||
index = self._read_json(self._index_file)
|
||||
step_context = self._build_step_context(index)
|
||||
preamble = self._build_preamble(guardrails, step_context, prev_error)
|
||||
preamble = self._build_preamble(guardrails, step_context, step.get("allowed_paths", []), prev_error)
|
||||
|
||||
tag = f"Step {step_num}/{self._total - 1} ({done} done): {step_name}"
|
||||
if attempt > 1:
|
||||
@@ -318,7 +455,7 @@ class StepExecutor:
|
||||
if s["step"] == step_num:
|
||||
s["completed_at"] = ts
|
||||
self._write_json(self._index_file, index)
|
||||
self._commit_step(step_num, step_name)
|
||||
self._commit_step(step, step_name)
|
||||
print(f" ✓ Step {step_num}: {step_name} [{elapsed}s]")
|
||||
return True
|
||||
|
||||
@@ -353,7 +490,7 @@ class StepExecutor:
|
||||
s["error_message"] = f"[{self.MAX_RETRIES}회 시도 후 실패] {err_msg}"
|
||||
s["failed_at"] = ts
|
||||
self._write_json(self._index_file, index)
|
||||
self._commit_step(step_num, step_name)
|
||||
self._commit_step(step, step_name)
|
||||
print(f" ✗ Step {step_num}: {step_name} failed after {self.MAX_RETRIES} attempts [{elapsed}s]")
|
||||
print(f" Error: {err_msg}")
|
||||
self._update_top_index("error")
|
||||
@@ -369,6 +506,7 @@ class StepExecutor:
|
||||
print("\n All steps completed!")
|
||||
return
|
||||
|
||||
self._validate_step_allowlist(pending)
|
||||
step_num = pending["step"]
|
||||
for s in index["steps"]:
|
||||
if s["step"] == step_num and "started_at" not in s:
|
||||
@@ -384,15 +522,22 @@ class StepExecutor:
|
||||
self._write_json(self._index_file, index)
|
||||
self._update_top_index("completed")
|
||||
|
||||
self._run_git("add", "-A")
|
||||
final_paths = [f"phases/{self._phase_dir_name}/index.json"]
|
||||
if self._top_index_file.exists():
|
||||
final_paths.append("phases/index.json")
|
||||
self._validate_before_commit(f"chore({self._phase_name}): mark phase completed")
|
||||
self._stage_paths(final_paths)
|
||||
if self._run_git("diff", "--cached", "--quiet").returncode != 0:
|
||||
msg = f"chore({self._phase_name}): mark phase completed"
|
||||
r = self._run_git("commit", "-m", msg)
|
||||
if r.returncode == 0:
|
||||
if r.returncode != 0:
|
||||
print(f" ERROR: phase completion commit failed: {r.stderr.strip()}")
|
||||
sys.exit(1)
|
||||
else:
|
||||
print(f" ✓ {msg}")
|
||||
|
||||
if self._auto_push:
|
||||
branch = f"feat-{self._phase_name}"
|
||||
branch = self._branch_name()
|
||||
r = self._run_git("push", "-u", "origin", branch)
|
||||
if r.returncode != 0:
|
||||
print(f"\n ERROR: git push 실패: {r.stderr.strip()}")
|
||||
|
||||
Reference in New Issue
Block a user