modify documents

2026-09-05 15:14:21 +09:00
parent 31dac85192
commit 97e4d7a971
79 changed files with 4570 additions and 2787 deletions
@@ -1,41 +1,55 @@
 ---
 name: review
-description: Use when reviewing repository changes against AGENTS.md, architecture decisions, tests, and build requirements.
+description: Review repository changes for structural FEM correctness, architecture boundaries, safety, tests, and evidence without modifying them.
 ---

 # Repository Review

-먼저 다음 문서를 읽는다.
+Review the requested diff, or the current working-tree changes when no range is given. This skill is
+read-only: do not fix findings unless the user separately asks for implementation.

- `/AGENTS.md`
- `/docs/ARCHITECTURE.md`
- `/docs/ADR.md`
+## Required context

-사용자가 범위를 지정하지 않으면 현재 작업 트리의 변경을 리뷰한다. 관련 diff를
-확인하고 가능한 빌드와 테스트 command를 실제로 실행한다.
+Read `AGENTS.md`, `docs/ARCHITECTURE.md`, `docs/ADR.md`, and the feature contracts directly affected by
+the diff. Read `docs/TOLERANCE.md` for numerical or comparison changes. Use repository configuration to
+discover actual build/test commands; do not assume a solver target exists.

-## 체크리스트
+## Review order

-1. MSVC toolset와 C++ 표준이 AGENTS.md/ADR과 일치하는가?
-2. CMake 또는 MSBuild Debug/x64 빌드가 통과하는가?
-3. CTest 또는 `.harness/config.json`의 명시적 test command가 통과하는가?
-4. 새 C/C++ 소스와 헤더에 대응 테스트가 있는가?
-5. CRITICAL 아키텍처 규칙과 public header 경계를 지키는가?
+1. Identify changed public behavior, physics meaning, I/O/result identity, state ownership, and
+   architecture boundaries.
+2. Check that every production C++ change has a test and that behavior changes show meaningful RED/GREEN
+   evidence.
+3. For numerical code, verify units, coordinates, sign, DOF/component ordering, residual/tangent
+   consistency, integration, trial/commit state, determinism, and tolerance ownership.
+4. For Abaqus-facing code, review only the declared observable subset and reject undocumented internal
+   equivalence claims or silent handling of unsupported semantics.
+5. Run the smallest relevant checks, then the configured full build/test when available. Record exact
+   commands and exit codes. An unavailable or skipped check is `not verified`, never `pass`.
+6. Check that reference inputs/results and tolerance artifacts were not changed to fit implementation
+   output, and that unrelated working-tree files are untouched.

-## 출력 형식
+## Findings

-실제 결함을 심각도순으로 먼저 제시한다. 각 finding에 파일과 줄 번호, 영향,
-재현 또는 근거, 구체적인 수정 방안을 포함한다.
+Report actionable defects first, ordered `critical`, `high`, `medium`, `low`. Each finding must contain:

-그 뒤 다음 표를 제공한다.
+- file and line
+- violated contract or observable risk
+- concrete evidence or reproduction
+- smallest credible correction

-| 항목 | 결과 | 비고 |
-|------|------|------|
-| 아키텍처 준수 | ✅/❌/미검증 | 상세 |
-| 기술 스택 준수 | ✅/❌/미검증 | 상세 |
-| 테스트 존재 | ✅/❌/미검증 | 상세 |
-| CRITICAL 규칙 | ✅/❌/미검증 | 상세 |
-| 빌드 가능 | ✅/❌/미검증 | 상세 |
+Do not report style preferences without a project rule or meaningful maintenance risk. Do not infer a
+defect solely because an external solver uses a different private implementation.

-실행할 수 없는 검사는 성공으로 추정하지 말고 `미검증`과 이유를 적는다. finding이
-없으면 발견된 문제가 없다고 명시하고 남아 있는 검증 공백을 설명한다.
+After findings, summarize:
+
+| Gate | Result | Evidence or gap |
+| --- | --- | --- |
+| Requirements/architecture | pass/fail/not verified | details |
+| Numerical and physical contract | pass/fail/not applicable/not verified | details |
+| Tests and TDD evidence | pass/fail/not verified | details |
+| Build/toolchain | pass/fail/not available/not verified | details |
+| Reference/tolerance integrity | pass/fail/not applicable/not verified | details |
+| Scope and repository safety | pass/fail/not verified | details |
+
+If no defect is found, say so explicitly and list residual risks or checks that could not be executed.