refactor: make coordinator the main workflow agent
This commit is contained in:
KOKO\Mimi
@@ -15,11 +15,16 @@ Read these first:
|
||||
- `docs/SOLVER_AGENT_DESIGN.md`
|
||||
- `docs/HARNESS.md`
|
||||
- `docs/HARNESS_WORKFLOW.md`
|
||||
- `docs/<feature-id>/requirements.md`
|
||||
- `docs/<feature-id>/research.md`
|
||||
- `docs/<feature-id>/formulation.md`
|
||||
- `docs/<feature-id>/numerical-review.md`
|
||||
- `docs/<feature-id>/reference-model.md`
|
||||
- `docs/<feature-id>/io.md`
|
||||
- `docs/<feature-id>/implementation-plan.md`
|
||||
- `docs/<feature-id>/implementation-report.md` when present
|
||||
- `docs/<feature-id>/build-test.md` when present
|
||||
- `docs/<feature-id>/reference-comparison.md` when present
|
||||
- Related requirements, formulation, numerical review, I/O definition, and reference model documents
|
||||
- Generated FESA `results.h5` and the exact feature-declared reference `.inp` and Abaqus CSV paths
|
||||
|
||||
For Harness implementation, also read `.agents/skills/harness/SKILL.md`,
|
||||
@@ -48,7 +53,7 @@ For Harness implementation, also read `.agents/skills/harness/SKILL.md`,
|
||||
11. Let Stop perform the final whole-project MSVC build/test before the Step ends.
|
||||
12. Record every build/test command, exit code, duration, stdout/stderr tail, failed test names, environment, and project-selection path. Stop after the first decisive failure unless the implementation plan requires another diagnostic command.
|
||||
13. For failure triage, classify as `configure | compile | link | test | reference-comparison | harness | environment | upstream-contract`.
|
||||
14. Run reference verification in this literal order: `ARTIFACT CHECK -> COMPARE -> CLASSIFY -> REPORT`.
|
||||
14. Run reference comparison in this literal order: `ARTIFACT CHECK -> COMPARE -> CLASSIFY -> REPORT`.
|
||||
15. ARTIFACT CHECK requires exact declared input/CSV paths, generated `results.h5`, the `io.md` HDF5 projection, source identity/component matching, row uniqueness/finite checks, and approved tolerance.
|
||||
16. COMPARE matches HDF5 and CSV rows by declared source identity and component, never by row order. Reject missing, extra, duplicate, and nonfinite required rows before tolerance; preserve warning-only behavior.
|
||||
17. Fix implementation-owned failures only and keep changes traceable to the implementation plan.
|
||||
@@ -122,10 +127,10 @@ uv run --with pytest python -m pytest -v -rs
|
||||
- Reference comparison records per-row decisions and, only where the approved feature contract
|
||||
makes each metric applicable, max absolute error, max relative or component-normalized error,
|
||||
RMS error, and norm error.
|
||||
- Correction attempts stop when repeated failure indicates upstream contract ambiguity.
|
||||
- Compile, link, test, and reference-comparison failures return to Implementation Agent first.
|
||||
- Repeated or unclear implementation failures route to Correction Agent through Coordinator Agent.
|
||||
- Automatic rework stops when the same normalized failure classification reaches two attempts.
|
||||
|
||||
## Handoff
|
||||
|
||||
Send `pass-for-physics-evaluation` evidence to Physics Evaluation Agent through Coordinator Agent.
|
||||
Send implementation-owned failures to Correction Agent through Coordinator Agent. Send upstream-contract
|
||||
failures to the owning upstream agent through Coordinator Agent.
|
||||
Return the applicable canonical outputs, status, evidence summary, and blockers to Coordinator Agent. Implementation Planning returns `docs/<feature-id>/implementation-plan.md` for one Implementation Agent handoff. Implementation returns `docs/<feature-id>/implementation-report.md`, `docs/<feature-id>/build-test.md`, and `docs/<feature-id>/reference-comparison.md`; send `pass-for-physics-evaluation` to Physics Evaluation Agent through Coordinator Agent. Correction returns `docs/<feature-id>/corrections.md` and a rerun request to Implementation Agent through Coordinator Agent. Return upstream-contract failures to Coordinator Agent for the owning upstream sub-agent.
|
||||
|
||||
@@ -13,9 +13,8 @@ Read these first:
|
||||
|
||||
- `AGENTS.md`
|
||||
- `docs/SOLVER_AGENT_DESIGN.md`
|
||||
- `docs/formulations/README.md`
|
||||
- `docs/requirements/<feature-id>.md`
|
||||
- `docs/research/<feature-id>-research.md`
|
||||
- `docs/<feature-id>/requirements.md`
|
||||
- `docs/<feature-id>/research.md`
|
||||
|
||||
## Workflow
|
||||
|
||||
@@ -32,7 +31,7 @@ Read these first:
|
||||
|
||||
## Output Contract
|
||||
|
||||
Produce or revise `docs/formulations/<feature-id>-formulation.md` with:
|
||||
Produce or revise `docs/<feature-id>/formulation.md` with:
|
||||
|
||||
- Scope and Assumptions
|
||||
- Primary Variables and DOFs
|
||||
@@ -63,7 +62,8 @@ Produce or revise `docs/formulations/<feature-id>-formulation.md` with:
|
||||
- Shape functions include partition of unity and Kronecker delta checks when applicable.
|
||||
- Jacobian, determinant validity, derivative transform, integration rule, and output location are explicit.
|
||||
- Missing research or requirements become open issues, not assumptions.
|
||||
- The document is `ready-for-numerical-review` only when all derivations, assumptions, output recovery rules, numerical risks, and open issues are explicit.
|
||||
|
||||
## Handoff
|
||||
|
||||
Send the formulation to Numerical Review Agent first. After review, pass implementation-relevant pseudocode and acceptance quantities to Implementation Planning Agent, I/O needs to I/O Definition Agent, and benchmarkable checks to Reference Model Agent.
|
||||
Return `docs/<feature-id>/formulation.md`, status, evidence summary, blockers, and all review evidence to Numerical Review Agent through Coordinator Agent. Do not bypass the numerical/reference gate with a downstream handoff.
|
||||
|
||||
@@ -13,10 +13,11 @@ Read these first:
|
||||
|
||||
- `AGENTS.md`
|
||||
- `docs/SOLVER_AGENT_DESIGN.md`
|
||||
- `docs/io-definitions/README.md`
|
||||
- `docs/requirements/<feature-id>.md`
|
||||
- `docs/formulations/<feature-id>-formulation.md`
|
||||
- Numerical review and reference model documents when present
|
||||
- `docs/<feature-id>/requirements.md`
|
||||
- `docs/<feature-id>/research.md`
|
||||
- `docs/<feature-id>/formulation.md`
|
||||
- `docs/<feature-id>/numerical-review.md`
|
||||
- `docs/<feature-id>/reference-model.md`
|
||||
|
||||
## Workflow
|
||||
|
||||
@@ -34,7 +35,7 @@ Read these first:
|
||||
|
||||
## Output Contract
|
||||
|
||||
Produce or revise `docs/io-definitions/<feature-id>-io.md` with:
|
||||
Produce or revise `docs/<feature-id>/io.md` with:
|
||||
|
||||
- Abaqus Input Scope
|
||||
- Syntax Policy
|
||||
@@ -63,7 +64,8 @@ Produce or revise `docs/io-definitions/<feature-id>-io.md` with:
|
||||
deterministic matching, and missing/extra/duplicate/nonfinite prechecks. Never match by row order alone.
|
||||
- Unsupported Abaqus input is explicit: unsupported, ignored-with-warning, or requires user decision.
|
||||
- The I/O contract is compatible with requirements, formulation, and reference comparison needs.
|
||||
- The final HDF5 projection maps every approved logical quantity and source identity from `docs/<feature-id>/reference-model.md` to deterministic dataset and CSV component identities.
|
||||
|
||||
## Handoff
|
||||
|
||||
Send keyword and schema contracts to Reference Model Agent and Implementation Planning Agent. Send HDF5 dataset paths, reference CSV row schemas, ID matching, and tolerance-source constraints to Reference Verification Agent.
|
||||
Return `docs/<feature-id>/io.md`, status, evidence summary, and blockers to Coordinator Agent. Route the final HDF5 projection, parser/schema contracts, exact CSV paths, source-ID/component matching, row prechecks, and tolerance-source constraints to Implementation Planning Agent through Coordinator Agent.
|
||||
|
||||
@@ -19,6 +19,7 @@ Read these first:
|
||||
- `docs/<feature-id>/research.md`
|
||||
- `docs/<feature-id>/formulation.md`
|
||||
- Existing stored reference artifacts under `reference/`, read-only
|
||||
- Coordinator Agent dispatch package for the numerical/reference gate
|
||||
|
||||
## Workflow
|
||||
|
||||
@@ -86,8 +87,10 @@ Produce or revise `docs/<feature-id>/reference-model.md` with:
|
||||
tolerance, or supported-keyword policy is undefined.
|
||||
- Canonical naming, README, metadata, provenance, extended portfolios, and unrequired CSV files do
|
||||
not block readiness.
|
||||
- Both canonical reports must return output paths, status, evidence summary, and blockers before the gate can pass.
|
||||
|
||||
## Handoff
|
||||
|
||||
Send both completed reports through Coordinator Agent to I/O Definition Agent. Send math defects to
|
||||
Formulation Agent, source gaps to Research Agent, and blocked decisions to Coordinator Agent.
|
||||
Return `docs/<feature-id>/numerical-review.md` and `docs/<feature-id>/reference-model.md`, status,
|
||||
evidence summary, and blockers to Coordinator Agent. Route both passed reports to I/O Definition
|
||||
Agent, math defects to Formulation Agent, and source gaps to Research Agent through Coordinator Agent.
|
||||
|
||||
@@ -1,6 +1,6 @@
|
||||
---
|
||||
name: fesa-physics-sanity
|
||||
description: Use when evaluating FESA solver physics and physical plausibility after reference verification, including equilibrium, reactions, displacement direction, symmetry, stress sanity, and model coverage.
|
||||
description: Use when evaluating FESA solver physics and physical plausibility after a passing implementation-owned reference comparison, including equilibrium, reactions, displacement direction, symmetry, stress sanity, and model coverage.
|
||||
---
|
||||
|
||||
# FESA Physics Sanity
|
||||
@@ -13,16 +13,18 @@ Read these first:
|
||||
|
||||
- `AGENTS.md`
|
||||
- `docs/SOLVER_AGENT_DESIGN.md`
|
||||
- `docs/physics-evaluations/README.md`
|
||||
- Reference Verification report with `pass-for-physics-evaluation`
|
||||
- `docs/reference-models/<feature-id>-reference-models.md`
|
||||
- Requirements, formulation, numerical review, and I/O definition documents
|
||||
- `docs/<feature-id>/reference-comparison.md` with `pass-for-physics-evaluation`
|
||||
- `docs/<feature-id>/reference-model.md`
|
||||
- `docs/<feature-id>/requirements.md`
|
||||
- `docs/<feature-id>/formulation.md`
|
||||
- `docs/<feature-id>/numerical-review.md`
|
||||
- `docs/<feature-id>/io.md`
|
||||
- Solver results.h5, feature-declared Abaqus reference CSV files, and optional FESA debug CSV views as read-only evidence
|
||||
|
||||
## Workflow
|
||||
|
||||
1. Evaluate only documented physical expectations.
|
||||
2. Require a reference verification status of `pass-for-physics-evaluation`.
|
||||
2. Require `pass-for-physics-evaluation` in `docs/<feature-id>/reference-comparison.md`.
|
||||
3. Check global equilibrium when loads, reactions, and sign conventions are documented.
|
||||
4. Check reaction consistency for constrained DOFs.
|
||||
5. Check displacement direction against loads, boundary conditions, and expected deformation mode.
|
||||
@@ -35,7 +37,7 @@ Read these first:
|
||||
|
||||
## Output Contract
|
||||
|
||||
Produce or revise `docs/physics-evaluations/<feature-id>-physics-evaluation.md` with:
|
||||
Produce or revise `docs/<feature-id>/physics-evaluation.md` with:
|
||||
|
||||
- Metadata
|
||||
- Input Evidence
|
||||
@@ -59,11 +61,11 @@ Produce or revise `docs/physics-evaluations/<feature-id>-physics-evaluation.md`
|
||||
|
||||
## Quality Gate
|
||||
|
||||
- A physics pass requires documented expectations and reference verification pass evidence.
|
||||
- A physics pass requires documented expectations and passing reference-comparison evidence.
|
||||
- Use `needs-upstream-decision` when physical expectations, sign convention, or model purpose is missing.
|
||||
- Use `needs-reference-model` only when a feature-required case or declared physical expectation is missing.
|
||||
- Route a feature-required case, declared physical expectation, or model-coverage gap to Numerical Review.
|
||||
- `pass-for-release-agent` means Release Agent can audit release readiness; it is not release approval.
|
||||
|
||||
## Handoff
|
||||
|
||||
Send `pass-for-release-agent` reports to Release Agent. Send implementation-owned physics failures to Correction Agent, formulation concerns to Formulation Agent, I/O ambiguity to I/O Definition Agent, and model coverage gaps to Reference Model Agent.
|
||||
Return `docs/<feature-id>/physics-evaluation.md`, status, evidence summary, and blockers to Coordinator Agent. Route `pass-for-release-agent` to Release Agent, implementation-owned failures to Correction Agent, formulation concerns to Formulation Agent, I/O ambiguity to I/O Definition Agent, and model-coverage gaps to Numerical Review Agent, always through Coordinator Agent.
|
||||
|
||||
@@ -13,17 +13,24 @@ Read these first:
|
||||
|
||||
- `AGENTS.md`
|
||||
- `docs/SOLVER_AGENT_DESIGN.md`
|
||||
- `docs/releases/README.md`
|
||||
- Physics Evaluation report with `pass-for-release-agent`
|
||||
- Reference Verification report with `pass-for-physics-evaluation`
|
||||
- Build/Test report with `pass-for-reference-verification`
|
||||
- Requirements, formulation, numerical review, I/O definition, reference model, implementation, and correction reports
|
||||
- `docs/<feature-id>/requirements.md`
|
||||
- `docs/<feature-id>/research.md`
|
||||
- `docs/<feature-id>/formulation.md`
|
||||
- `docs/<feature-id>/numerical-review.md`
|
||||
- `docs/<feature-id>/reference-model.md`
|
||||
- `docs/<feature-id>/io.md`
|
||||
- `docs/<feature-id>/implementation-plan.md`
|
||||
- `docs/<feature-id>/implementation-report.md`
|
||||
- `docs/<feature-id>/build-test.md` with passing full validation evidence
|
||||
- `docs/<feature-id>/reference-comparison.md` with `pass-for-physics-evaluation`
|
||||
- `docs/<feature-id>/corrections.md` when correction occurred
|
||||
- `docs/<feature-id>/physics-evaluation.md` with `pass-for-release-agent`
|
||||
|
||||
## Workflow
|
||||
|
||||
1. Follow `GATE AUDIT -> TRACEABILITY CHECK -> RELEASE DOCUMENTATION -> RELEASE VERDICT`.
|
||||
2. GATE AUDIT: confirm required reports exist, share the same `feature_id`, are not stale or contradictory, and carry required pass statuses.
|
||||
3. Require `pass-for-reference-verification`, `pass-for-physics-evaluation`, and `pass-for-release-agent`.
|
||||
3. Require passing full validation evidence, `pass-for-physics-evaluation`, and `pass-for-release-agent`.
|
||||
4. TRACEABILITY CHECK: confirm each `must` requirement maps to acceptance criteria, test evidence,
|
||||
feature-required reference evidence when applicable, and release scope.
|
||||
5. Record deferred requirements, unsupported Abaqus keywords, missing required comparison files,
|
||||
@@ -33,7 +40,7 @@ Read these first:
|
||||
|
||||
## Output Contract
|
||||
|
||||
Produce or revise `docs/releases/<feature-id>-release.md` with:
|
||||
Produce or revise `docs/<feature-id>/release.md` with:
|
||||
|
||||
- Metadata
|
||||
- Release Scope
|
||||
@@ -58,7 +65,7 @@ Produce or revise `docs/releases/<feature-id>-release.md` with:
|
||||
|
||||
## Quality Gate
|
||||
|
||||
- Do not issue `ready-for-release` without `pass-for-release-agent`, `pass-for-physics-evaluation`, and `pass-for-reference-verification`.
|
||||
- Do not issue `ready-for-release` without `pass-for-release-agent`, `pass-for-physics-evaluation`, and passing full build/test evidence.
|
||||
- Every `must` requirement traces to release scope, acceptance criteria, test or reference evidence, and final disposition.
|
||||
- Known limitations and deferred issues are included in the Release Notes Draft.
|
||||
- Missing required evidence, contradictory reports, unresolved defects, missing declared comparison
|
||||
@@ -67,4 +74,4 @@ Produce or revise `docs/releases/<feature-id>-release.md` with:
|
||||
|
||||
## Handoff
|
||||
|
||||
Send `ready-for-release` to Coordinator Agent for final workflow closure. Send missing documentation to Release Agent revision, missing verification to Reference Verification Agent or Physics Evaluation Agent, and implementation defects to Correction Agent.
|
||||
Return `docs/<feature-id>/release.md`, status, evidence summary, blockers, and a closure recommendation to Coordinator Agent. Return missing implementation/build/comparison evidence, missing physics evidence, upstream gaps, or documentation gaps to Coordinator Agent for the owning sub-agent; do not advance or close the workflow directly.
|
||||
|
||||
@@ -13,9 +13,8 @@ Read these first:
|
||||
|
||||
- `AGENTS.md`
|
||||
- `docs/SOLVER_AGENT_DESIGN.md`
|
||||
- `docs/requirements/README.md`
|
||||
- User feature request, target capability, constraints, and known exclusions
|
||||
- Existing `docs/requirements/<feature-id>.md` when revising a feature
|
||||
- Existing `docs/<feature-id>/requirements.md` when revising a feature
|
||||
|
||||
## Workflow
|
||||
|
||||
@@ -31,7 +30,7 @@ Read these first:
|
||||
|
||||
## Output Contract
|
||||
|
||||
Produce or revise `docs/requirements/<feature-id>.md` with:
|
||||
Produce or revise `docs/<feature-id>/requirements.md` with:
|
||||
|
||||
- Metadata with `feature_id`, status, owner agent, and date
|
||||
- Purpose, In Scope, Out Of Scope, and Analysis Definition
|
||||
@@ -60,7 +59,8 @@ Produce or revise `docs/requirements/<feature-id>.md` with:
|
||||
- Do not require canonical names, README, metadata, provenance, or CSVs for quantities outside
|
||||
the feature acceptance boundary.
|
||||
- Words like "accurate", "fast", and "Abaqus-like" are converted into measurable criteria or open questions.
|
||||
- Return reference artifact, comparison quantity, source-identity/component, and tolerance gaps for Numerical Review rather than inventing acceptance rules.
|
||||
|
||||
## Handoff
|
||||
|
||||
Route theory gaps to Research Agent, math gaps to Formulation Agent, schema gaps to I/O Definition Agent, reference artifact needs to Reference Model Agent, and implementation readiness to Implementation Planning Agent.
|
||||
Return `docs/<feature-id>/requirements.md`, status, evidence summary, and blockers to Coordinator Agent. Route theory questions to Research Agent and reference acceptance, artifact, identity/component, and tolerance questions to Numerical Review Agent through Coordinator Agent.
|
||||
|
||||
@@ -13,8 +13,7 @@ Read these first:
|
||||
|
||||
- `AGENTS.md`
|
||||
- `docs/SOLVER_AGENT_DESIGN.md`
|
||||
- `docs/research/README.md`
|
||||
- `docs/requirements/<feature-id>.md`
|
||||
- `docs/<feature-id>/requirements.md`
|
||||
- User-supplied books, papers, manuals, or benchmark constraints
|
||||
|
||||
## Workflow
|
||||
@@ -29,7 +28,7 @@ Read these first:
|
||||
|
||||
## Output Contract
|
||||
|
||||
Produce or revise `docs/research/<feature-id>-research.md` with:
|
||||
Produce or revise `docs/<feature-id>/research.md` with:
|
||||
|
||||
- Metadata and source requirement path
|
||||
- Research Questions
|
||||
@@ -55,7 +54,8 @@ Produce or revise `docs/research/<feature-id>-research.md` with:
|
||||
- Benchmark candidates include what quantity they can verify and what they cannot verify.
|
||||
- Missing source evidence is carried forward as an open issue.
|
||||
- No reference value, tolerance, or compatibility claim is invented.
|
||||
- Benchmark/reference evidence identifies exact candidate artifacts, target quantities, applicability limits, and unresolved acceptance questions for Numerical Review.
|
||||
|
||||
## Handoff
|
||||
|
||||
Send formulation evidence to Formulation Agent, benchmark and source limits to Numerical Review Agent, artifact candidates to Reference Model Agent, and unresolved source gaps to Coordinator Agent.
|
||||
Return `docs/<feature-id>/research.md`, status, evidence summary, and blockers to Coordinator Agent. Route formulation evidence to Formulation Agent and benchmark/reference evidence, artifact candidates, and source limits to Numerical Review Agent through Coordinator Agent.
|
||||
|
||||
Reference in New Issue
Block a user