refactor: merge reference model into numerical review
This commit is contained in:
@@ -1,11 +1,13 @@
|
||||
---
|
||||
name: fesa-numerical-review
|
||||
description: Use when independently reviewing FESA FEM numerical review evidence, formulation correctness, stability risks, patch tests, locking, Jacobian handling, and implementation planning readiness.
|
||||
description: Use when independently reviewing FESA FEM formulation numerical correctness, stability risks, verification readiness, and existing reference-case input/CSV readiness before I/O definition.
|
||||
---
|
||||
|
||||
# FESA Numerical Review
|
||||
# FESA Numerical and Reference Review
|
||||
|
||||
Use this skill to review a formulation as a numerical algorithm contract before implementation planning.
|
||||
Use this skill to review a formulation as a numerical algorithm contract and to inventory the
|
||||
minimum existing reference inputs and CSV quantities required by the approved feature scope before
|
||||
I/O definition.
|
||||
|
||||
## Inputs
|
||||
|
||||
@@ -13,27 +15,33 @@ Read these first:
|
||||
|
||||
- `AGENTS.md`
|
||||
- `docs/SOLVER_AGENT_DESIGN.md`
|
||||
- `docs/numerical-reviews/README.md`
|
||||
- `docs/formulations/<feature-id>-formulation.md`
|
||||
- Related requirements and research documents when needed
|
||||
- `docs/<feature-id>/requirements.md`
|
||||
- `docs/<feature-id>/research.md`
|
||||
- `docs/<feature-id>/formulation.md`
|
||||
- Existing stored reference artifacts under `reference/`, read-only
|
||||
|
||||
## Workflow
|
||||
|
||||
1. Lead with findings and required revisions.
|
||||
2. Check dimensional consistency, signs, DOF ordering, constrained/free assumptions, and coordinate transforms.
|
||||
3. Review B matrix or kinematic operator consistency.
|
||||
4. Review constitutive matrix or stress update contract.
|
||||
5. Review Jacobian rules, determinant checks, derivative transforms, and distortion handling.
|
||||
6. Review integration rule, Gauss points, weights, and full/reduced/selective integration policy.
|
||||
7. Check element residual, internal force, external force, stiffness, tangent, symmetry, and positive definiteness expectations.
|
||||
8. Assess only rigid modes, patch tests, locking, singularity, conditioning, convergence, and
|
||||
other risks required by the approved feature scope. Do not invent calibration or portfolio gates.
|
||||
9. Decide status: `pass-for-implementation-planning`, `needs-formulation-revision`,
|
||||
`needs-research`, or `blocked`.
|
||||
FORMULATION REVIEW -> REFERENCE CASE INVENTORY -> CLASSIFY -> REPORT -> I/O HANDOFF
|
||||
|
||||
1. **FORMULATION REVIEW:** Lead with findings and required revisions. Check dimensions, signs,
|
||||
DOF ordering, constrained/free assumptions, coordinate transforms, kinematic operator,
|
||||
constitutive contract, Jacobian and derivative rules, integration policy, residual/force/stiffness
|
||||
consistency, and only the feature-approved stability and verification risks.
|
||||
2. **REFERENCE CASE INVENTORY:** List each existing case using its exact directory, input filename,
|
||||
and required CSV filenames. Confirm declared input and every required comparison CSV are present
|
||||
and readable without renaming, repairing, normalizing, generating, or modifying artifacts.
|
||||
Define logical blocking and warning-only quantities, source identity/component matching, row
|
||||
prechecks for missing, extra, duplicate, and nonfinite required rows, and the approved tolerance.
|
||||
3. **CLASSIFY:** Use only `pass-for-io-definition`, `needs-formulation-revision`,
|
||||
`needs-research`, `needs-reference-artifacts`, `needs-user-decision`, or `blocked`.
|
||||
4. **REPORT:** Produce both reports in the Output Contract.
|
||||
5. **I/O HANDOFF:** Send both reports through Coordinator Agent to I/O Definition Agent. I/O
|
||||
Definition owns the final HDF5 dataset projection; this review owns logical quantities and source identity.
|
||||
|
||||
## Output Contract
|
||||
|
||||
Produce or revise `docs/numerical-reviews/<feature-id>-review.md` with:
|
||||
Produce or revise `docs/<feature-id>/numerical-review.md` with:
|
||||
|
||||
- Metadata and source formulation
|
||||
- Review Verdict
|
||||
@@ -44,27 +52,41 @@ Produce or revise `docs/numerical-reviews/<feature-id>-review.md` with:
|
||||
- Required Revisions
|
||||
- Downstream Handoff
|
||||
|
||||
Produce or revise `docs/<feature-id>/reference-model.md` with:
|
||||
|
||||
- Metadata
|
||||
- Reference Acceptance Scope
|
||||
- Reference Case Inventory: exact input and required CSV paths
|
||||
- Source Identity and Component Contract: logical quantity, source identity, component matching,
|
||||
and blocking or warning-only classification
|
||||
- Row Prechecks: missing, extra, duplicate, and nonfinite required rows fail before tolerance
|
||||
- Tolerance and Blocking/Warning Policy: exact approved tolerance without invention or calibration
|
||||
- Open Issues and I/O Handoff: logical quantity and source identity information for the I/O contract
|
||||
|
||||
## Boundaries
|
||||
|
||||
- Do not implement code.
|
||||
- Do not edit formulations directly.
|
||||
- Do not design C++ APIs or file ownership.
|
||||
- Do not run Abaqus, Nastran, or any reference solver.
|
||||
- Do not generate or modify Abaqus reference CSV files.
|
||||
- Do not generate, rename, repair, normalize, or modify reference inputs or CSV files.
|
||||
- Do not approve release readiness.
|
||||
- Do not decide reference comparison success.
|
||||
- Do not include final HDF5 dataset paths; I/O Definition owns that projection.
|
||||
|
||||
## Quality Gate
|
||||
|
||||
- `pass-for-implementation-planning` means implementation planning may begin, not that the feature is complete.
|
||||
- `pass-for-io-definition` means both reviews are ready for I/O definition, not that the feature is complete.
|
||||
- Confirmed defects, risks, open questions, and test recommendations are separated.
|
||||
- Missing derivations are returned to Formulation Agent instead of being silently fixed.
|
||||
- Evidence gaps are routed to Research Agent or Reference Model Agent.
|
||||
- Missing downstream Reference Model documents, canonical naming, README, metadata, provenance,
|
||||
extended portfolios, or comparison results do not block a formulation verdict.
|
||||
- Missing theory or benchmark evidence is routed to Research Agent.
|
||||
- Use `needs-reference-artifacts` only when a declared input or required comparison CSV is missing.
|
||||
- Use `needs-user-decision` only when a required quantity, source identity/component match,
|
||||
tolerance, or supported-keyword policy is undefined.
|
||||
- Canonical naming, README, metadata, provenance, extended portfolios, and unrequired CSV files do
|
||||
not block readiness.
|
||||
|
||||
## Handoff
|
||||
|
||||
Send pass results to Implementation Planning Agent and optional test notes to Reference Model
|
||||
Agent. Send math defects to Formulation Agent, source gaps to Research Agent, and blocked decisions
|
||||
to Coordinator Agent.
|
||||
Send both completed reports through Coordinator Agent to I/O Definition Agent. Send math defects to
|
||||
Formulation Agent, source gaps to Research Agent, and blocked decisions to Coordinator Agent.
|
||||
|
||||
@@ -1,4 +1,4 @@
|
||||
interface:
|
||||
display_name: "FESA Numerical Review"
|
||||
short_description: "Review FEM numerical risks"
|
||||
default_prompt: "Use $fesa-numerical-review to review FESA formulation numerical readiness."
|
||||
display_name: "FESA Numerical and Reference Review"
|
||||
short_description: "Review numerical and reference readiness"
|
||||
default_prompt: "Use $fesa-numerical-review to review FESA numerical and reference-model readiness."
|
||||
|
||||
Reference in New Issue
Block a user