baram2584/FESADev
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

docs: use fixed MITC4 reference tolerance

Browse Source
This commit is contained in:
KOKO\Mimi
2026-08-13 10:06:45 +09:00
parent 8994ce93f8
commit f1be807e40
14 changed files with 110 additions and 80 deletions
Download Patch File Download Diff File Expand all files Collapse all files
docs/implementation-plans/linear-static-mitc4-shell-implementation-plan.md
+13 -10
View File
@@ -277,8 +277,9 @@ order even when the minimal dependency set below is smaller.
- Consume exactly one declared input and displacement CSV per case; map instance,
source node and six displacement components directly to HDF5.
- Precheck header/row set/duplicates/nonfinite/schema/identity before numeric work.
- Apply `1e-9+1e-6*reference_scale_c`; U blocks, UR only emits deterministic warning;
record all required metrics and worst row.
- Apply fixed absolute `1.0e-5` to every U/UR row without a scale-dependent decision
term; U blocks, UR only emits deterministic warning; record all required metrics
and worst row.
- Tests: `MITC4-REF-001` through `MITC4-REF-006`.
### TASK-14: `shell-s4-end-to-end`
@@ -364,7 +365,7 @@ order even when the minimal dependency set below is smaller.
| MITC4-FLOW-004 | failed output may commit state | candidate state/output commits only after validation | `LinearStaticCli.*` |
| MITC4-REF-001 | six-column CSV header unsupported | exact MITC4 header maps instance/node/U/UR | `Mitc4ReferenceComparison.*` |
| MITC4-REF-002 | invalid row inventory may be ignored | missing/extra/duplicate/nonfinite/schema mismatch fails first | `Mitc4ReferenceComparison.*` |
| MITC4-REF-003 | tolerance could clamp/row-normalize | exact component group scale and mixed tolerance | `Mitc4ReferenceComparison.*` |
| MITC4-REF-003 | tolerance could remain scale-dependent or clamp/row-normalize | exact fixed absolute `1.0e-5` for every U/UR row | `Mitc4ReferenceComparison.*` |
| MITC4-REF-004 | UR may block verdict | U blocks; UR only warns | `Mitc4ReferenceComparison.*` |
| MITC4-REF-005 | report metrics/order incomplete | row decisions, max, normalized, RMS, vector, worst row deterministic | `Mitc4ReferenceComparison.*` |
| MITC4-REF-006 | comparator may require administrative files | only declared input/CSV/HDF5 required | `Mitc4ReferenceComparison.*` |
@@ -521,8 +522,8 @@ once without gap or overlapping requirement range.
| 055 | TASK-16 | VERIFY scope audit | N/A | extra benchmark portfolio is explicitly nonblocking and absent from completion gate |
| 056 | TASK-04, TASK-05, TASK-07, TASK-10 | KERNEL-005..007, PHYSREC-001, ASM-001/002, REC-003 | N/A | exact fixed drilling, deterministic rank/action and physical-output exclusion |
| 057 | TASK-10, TASK-12, downstream Physics Evaluation | REC-002..004, FLOW-002, later physics report | `shell-s4` | implementation exposes equilibrium/sign/energy evidence; physical plausibility verdict is downstream |
| 058-060 | TASK-13, TASK-14 | REF-003 and S4 E2E comparison | `shell-s4` | exact U mixed tolerance without clamp |
| 061-062 | TASK-13, TASK-14 | REF-004/005 and S4 E2E test | `shell-s4` | UR same tolerance, deterministic warning only |
| 058-060 | TASK-13, TASK-14 | REF-003 and S4 E2E comparison | `shell-s4` | exact fixed absolute U tolerance `1.0e-5` without scale/clamp |
| 061-062 | TASK-13, TASK-14 | REF-004/005 and S4 E2E test | `shell-s4` | UR fixed absolute `1.0e-5`, deterministic warning only |
| 063-064 | TASK-13 | REF-001/002/005 | `shell-s4` | schema/row failure before numeric comparison; full metrics |
| 065-068 | TASK-13, TASK-14, TASK-15 | REF-001/002/006, S4 case precheck and S4R non-consumption/common-path evidence | `shell-s4` | exact two S4 paths; unique finite mapped rows; no S4R artifact consumption |
| 069-071 | TASK-14, TASK-15 | S4 E2E suite and S4R common-path tests | `shell-s4` | S4 U blocks/UR warns; S4R mapping has no Abaqus equality gate |
@@ -882,16 +883,18 @@ ctest --test-dir .harness/build -C Debug --output-on-failure
- Scope ownership: this one test-only reference module owns TASK-13 comparator behavior
plus TASK-14 declared-case tests; it owns no solver production module.
- Prerequisite: Step 12 `completed` and valid MITC4 HDF5 fixture.
- RED: add REF-001..006 plus E2E-S4-001/002 before the comparator
implementation; build the reference target and run
- RED: update REF-003 first so the existing scale-dependent comparator fails against
literal fixed-boundary cases around `1.0e-5`; build the reference target and run
`ctest --test-dir .harness/build -C Debug -R "Mitc4ReferenceComparison|Mitc4S4Reference" --output-on-failure`.
Record the missing comparator/declared-case failure.
- GREEN: minimally add test-only comparator for exact shell CSV/HDF5 contract.
Record the expected old-tolerance assertion failure.
- GREEN: minimally replace only the MITC4 comparator decision value with fixed absolute
`1.0e-5`; keep reference scale as diagnostic report data only.
- If a declared case exposes a production defect outside this reference-test module,
stop the Step and route a focused correction to the owning prior module; do not patch
unrelated production layers inside this Step.
- VERIFY: focused comparator and the declared S4 tests, then common full VERIFY.
- Prohibitions: no reference artifact writes/Abaqus run, no metadata/README gate, no UR blocking.
- Prohibitions: no reference artifact writes/Abaqus run, no metadata/README gate, no UR
blocking, no B33 comparator change, and no scale/clamp substitution for fixed `1.0e-5`.
After explicit approval, planning may create only: